Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 --- Comment #5 from Vitezslav Crhonek <vcrhonek@xxxxxxxxxx> 2009-02-06 05:42:34 EDT --- (In reply to comment #4) > (In reply to comment #3) > > > kbd.src:20: W: unversioned-explicit-obsoletes console-tools > > > kbd.src:20: W: unversioned-explicit-obsoletes open > > > kbd.src:21: W: unversioned-explicit-provides console-tools > > > kbd.src:21: W: unversioned-explicit-provides open > > OK, Obsoletes is very historical here and it's probably safe to remove it, I'm > > just not sure about Provides... I'm not able to find good information on > > Provides/Obsoletes (if console-tools and open Provides are needed by other some > > package), what do you think? > > > According to: > [wolfy@wolfy tmp]$ repoquery --whatrequires open --repoid=development > [wolfy@wolfy tmp]$ repoquery --whatrequires console-tools > --repoid=development > you can drop the Provides, too. No one seems to require them. Fixed. > > > > > > kbd.src:73: E: hardcoded-library-path in > > > $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz > > > kbd.src:76: E: hardcoded-library-path in > > > $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz > > > kbd.src:80: E: hardcoded-library-path in > > > $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz > > > kbd.src:109: E: hardcoded-library-path in /lib/kbd > > We want /lib/kbd for every architecture, so I'll not change this. > OK. > > > > > > kbd.src: W: no-url-tag > > There's no kbd homepage. > How about http://ftp.altlinux.org/pub/people/legion/kbd ? Well, same URL is in source... But you're probably right, it's better for users than nothing. Fixed. > > > > > At least the COPYING file from the root dir should be included as %doc. I > > > suggest to also add doc/dvorak > > I agree with COPYING, but disagree with doc/dvorak. I think people that already > > are using dvorak don't need this kind of info and others much less:) > Well, say I'd like to give Dvorak a spin and I'll use it side by side with the > normal QWERTY layout for a while. Wouldn't I need the docs? Having them on my > system might be more convenient than browsing the net for them. Fine, I see it might be useful, so it's added. All changes are written to the CVS, let me know if you have anything else. Thanks for review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review