Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 --- Comment #3 from Vitezslav Crhonek <vcrhonek@xxxxxxxxxx> 2009-02-05 10:17:41 EDT --- (In reply to comment #1) Hi, you are right, I'm maintaining kbd currently. > rpmlint is not really happy at all: > rpmlint of source RPM: > kbd.src:20: W: unversioned-explicit-obsoletes console-tools > kbd.src:20: W: unversioned-explicit-obsoletes open > kbd.src:21: W: unversioned-explicit-provides console-tools > kbd.src:21: W: unversioned-explicit-provides open OK, Obsoletes is very historical here and it's probably safe to remove it, I'm just not sure about Provides... I'm not able to find good information on Provides/Obsoletes (if console-tools and open Provides are needed by other some package), what do you think? > kbd.src:23: E: prereq-use initscripts >= 5.86-1 Fixed (changed to plain Requires). > kbd.src:73: E: hardcoded-library-path in > $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz > kbd.src:76: E: hardcoded-library-path in > $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz > kbd.src:80: E: hardcoded-library-path in > $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz > kbd.src:109: E: hardcoded-library-path in /lib/kbd We want /lib/kbd for every architecture, so I'll not change this. > kbd.src: W: no-url-tag There's no kbd homepage. > > rpmlint of kbd: > kbd.x86_64: W: file-not-utf8 /usr/share/doc/kbd-1.15/ChangeLog Fixed. > kbd.x86_64: W: no-url-tag See above. > > > I think that --localedir=/usr/share/locale should be replaced with > --localedir=%_datadir/locale Fixed. > > At least the COPYING file from the root dir should be included as %doc. I > suggest to also add doc/dvorak I agree with COPYING, but disagree with doc/dvorak. I think people that already are using dvorak don't need this kind of info and others much less:) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review