Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477570 Hubert Plociniczak <hubert@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hubert@xxxxxxxxxx --- Comment #2 from Hubert Plociniczak <hubert@xxxxxxxxxx> 2009-02-04 12:58:41 EDT --- I am sure Peter will follow with the proper review, but here are some bits that I found in my informal review: - put Requires(preun) into single line - %{_sysconfdir}/sysconfig/couchdb instead of ${_sysconfdir}/default/couchdb - you have %exclude %{_sysconfdir}/rc.d/couchdb %{_sysconfdir}/rc.d/couchdb - use %{_initrddir} instead of %{_sysconfdir} - init-script must not be marked as %config (http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscript_packaging) - if you use %{_localstatedir} then use it consistently, for example in useradd or sed - use -D flag in 'install' instead of 'mkdir -p $RPM_BUILD_ROOT%{_initrddir}' - remove 'exit 0' in %pre - remove 'shadow-utils' since it is on ExceptionsList (http://fedoraproject.org/wiki/Packaging:Guidelines) - shouldn't mochiweb be a separate sub-package? - fix the obvious rpmlint warnings, like permissions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review