Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-08-14 04:11 EST ------- Hello. ======================================================= I cannot sponsor you formally because I do not have a member of sponsors. You may ask someone to review you on fedora-extras mailing list, for example. ======================================================= However, I do a kind of pre-review of your package. Note: my review cannot be a formal review. First, please read http://fedoraproject.org/wiki/Packaging/Guidelines . Then: * rpmlint is not silent. Fix below unless you have a opinion not to do so. gcin-1.2.1-2.i386.rpm: W: gcin summary-not-capitalized gcin - Chinese input method server W: gcin no-version-in-last-changelog W: gcin no-soname /usr/lib/libgcin-im-client.so E: gcin script-without-shellbang /etc/X11/xinit/xinput.d/gcin W: gcin devel-file-in-non-devel-package /usr/include/gcin-im-client.h gcin-1.2.1-2.src.rpm: W: gcin summary-not-capitalized gcin - Chinese input method server E: gcin unknown-key GPG#476a8659 W: gcin hardcoded-packager-tag Chung-Yen W: gcin setup-not-quiet E: gcin use-of-RPM_SOURCE_DIR W: gcin mixed-use-of-spaces-and-tabs gcin-debuginfo-1.2.1-2.i386.rpm: W: gcin-debuginfo no-version-in-last-changelog * This package doesn't be rebuilt in mock. Check the missing BuildRequires. In mock, this build of this package shows: gmake[2]: Entering directory `/builddir/build/BUILD/gcin-1.2.1' gcc -o gcin gcin.o eve.o win0.o pho.o tsin.o win1.o util.o pho-util.o gcin-conf.o tsin-util.o win-sym.o intcode.o pho-sy m.o win-int.o win-pho.o gcin-settings.o table-update.o win-gtab.o gtab.o gtab-util.o phrase.o win-inmd-switch.o pho-dbg.o locale.o win-pho-near.o gcin-switch.o win-status.o IC.o IMdkit/lib/libXimd.a im-srv/im-srv.a -lXtst -L/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lgli b-2.0 -L/usr/X11R6/lib /usr/bin/ld: cannot find -lXtst collect2: ld returned 1 exit status gmake[2]: *** [gcin] Error 1 * Commands needed for %post and so on which are in the paths normal users don't use (such as /usr/sbin) must be used with full path. * Why does this package have the definition of %prefix or %Docdir ? I strongly suspect this is not necessary. Especially, unless you have a reason that this package can be relocatable, removing %prefix is necessary. * Check files which this package should have. I suspect that this package should own %{_datadir}/gcin/ . * Check %Require. Is a explicit requirement of gtk2 is necessary? * Don't use Packager. Fedora buildsys overrides it. * The format of BuildRoot is not preferred. Especially, why use %{_builddir}, not %{_tmppath}? * Perhaps the description of Group is not proper. * Using of %makeinstall is now discouraged. * debuginfo rpm includes no files. Perhaps binaries in this package is stripped in build or install stages, which is incorrect and needs fixing. * Use macro, instead of using /etc and so on. * Don't use $RPM_SOURCE_DIR, use %SOURCE?? so that we can check where the sources is used easier. * Specify the location of %Source0 by URL, not by only the filename. Note: I didn't check this package by using this. I only checked packaging issue. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review