Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474356 --- Comment #15 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-02-04 05:01:51 EDT --- OK package named correctly OK spec file named correctly OK meets the Packaging Guidelines (except for above) OK license is correct, approved and in %doc OK license field in the package spec file matches the actual license OK package MUST successfully compile and build into binary rpms on at least one primary architecture (compiles on x86 cleanly) OK owns all directories OK doesn't contain any duplicate files OK permissions are correctly set OK clean section present OK uses macros consistently OK package contains code OK no large documentation files OK if a package includes something as %doc, it must not affect the runtime of the application. OK packages must not own files or directories already owned by other packages. OK %install MUST run rm -rf %{buildroot} OK all filenames must be valid UTF-8 The only remaining issue is file-not-utf8 /usr/share/doc/trilead-ssh2-213/HISTORY.txt "Michaël" is not actually UTF-8 in this file. Just put the next line in the %prep and we are good to go. iconv -f ISO-8859-1 -t UTF-8 -o HISTORY.txt HISTORY.txt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review