Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481224 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-02-03 05:55:14 EDT --- * In some cases you don't need to create directories before installing files to them, because 'install' utility has special switch '-D'. E.g. instead of mkdir -p %{buildroot}%{_initrddir} install -m 0755 %SOURCE1 %{buildroot}%{_initrddir}/rabbitmq-server you may write install -D -m 0755 %SOURCE1 %{buildroot}%{_initrddir}/rabbitmq-server * Invoke 'install' with '-p' switch while installing files (in order to preserve timestamps). * This line should be removed (looks like leftover) chmod 0755 %{buildroot}%{_initrddir}/rabbitmq-server * you should consider using rm %{_maindir}/{LICENSE,LICENSE-MPL-RabbitMQ,INSTALL} instead of rm %{_maindir}/LICENSE %{_maindir}/LICENSE-MPL-RabbitMQ %{_maindir}/INSTALL * regarding init-script. It should not be started by default. So, please, fix chkconfig's header from #chkconfig: 2345 80 05 to #chkconfig: - 80 05 You should fix init-header also. * It's a generally good idea to move some commandline switches from start section of initscript to /etc/sysconfig/%{name} See this, for example: http://cvs.fedoraproject.org/viewvc/rpms/ejabberd/devel/ejabberd.init?view=markup http://cvs.fedoraproject.org/viewvc/rpms/ejabberd/devel/ejabberd.sysconfig?view=markup -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review