Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225744 --- Comment #3 from Zdenek Prikryl <zprikryl@xxxxxxxxxx> 2009-02-03 04:09:38 EDT --- (In reply to comment #1) > * change buildroot to be guidelines compliant Fixed. > * add comment why %{?_smp_mflags} cannot be used fbset doesn't use autotool's stuff, it is written by hand. So, you have to use CFLAGS variable to pass additional options to the gcc. > * add comment why make install DESTDIR=%{buildroot} cannot be used This is a similar problem like above. In the makefile, there is no such variable. There is a $(PREFIX) variable which is set by %makeinstall > * add noreplace to the config (to silence rpmlint) Fixed. I committed the new spec into cvs. Please, review it, so I can bump a new release. Zdenek -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review