Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480851 --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-02-02 18:59:48 EDT --- (In reply to comment #1) > My review. I cannot sponsor you as I'm not (yet) an approved packager. > Once this package gets approved contact a sponsor from the official list. Thanks, I don't need a sponsor. > Requires: libcrypt.so.1 (noticed this requirement during build) > To be checked... see below > Good. Wondering if the following line is relevant for the description: > "which is the U.S. government's chosen candidate for the Advanced > Encryption Standard." Your call. I removed some sentences. > Will you be able to fix the build problem on PPC? Otherwise, add a tag to > exclude it. > Via koji I was able to build on ppc. I will exclude ppc64 for the moment. This is my second package with issues about openssl on ppcX. > - MUST: All build dependencies must be listed in BuildRequires, except for any > that are listed in the exceptions section of the Packaging Guidelines ; > inclusion of those as BuildRequires is optional. Apply common sense. > > You need the glibc-devel package for -lcrypt I don't think that I need glibc-devel. The koji log shows that the check for -lcrypt is ok without BR glibc-devel. But maybe I'm mistaken... http://koji.fedoraproject.org/koji/getfile?taskID=1100286&name=build.log Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/ccrypt.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/ccrypt-1.7-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review