Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483505 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-02-01 21:18:50 EDT --- Review: + package builds in mock (rawhide i386). koji build=>http://koji.fedoraproject.org/koji/taskinfo?taskID=1097838 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 933fdf283a0d2739f7630420569e3b24 PerlIO-gzip-0.18.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=2, Tests=561, 0 wallclock secs ( 0.07 usr 0.00 sys + 0.70 cusr 0.07 csys = 0.84 CPU) + Package perl-PerlIO-gzip-0.18-1.fc11 -> Provides: gzip.so perl(PerlIO::gzip) = 0.18 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libz.so.1 perl >= 0:5.008 perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review