Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483187 --- Comment #2 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> 2009-02-01 08:52:02 EDT --- > So shall we call this package "kde-plasma-weatherforecast" instead? It's under extragear/base/plasma/applets/weather in KDE SVN, that's where the name "weather" comes from. > * please make use of the %{name} macro. What for? It's not like the name is going to change frequently. That's just useless use of macros which doesn't help anyone. > Version: 0 I thought the recommended version to use for checkouts without a version was 0.0, maybe it changed or maybe I just remembered wrong. (I see they use just 0 in Packaging:NamingGuidelines.) But if I change it from 0.0 to 0 now, this will break the upgrade path for those who already installed the package from kde-redhat testing. 0.0 will upgrade just fine to any version number they'll actually use. > Release: 0.2.20090130svn%{?dist} OK, I can put the %{?dist} at the end, not sure why I put it before, probably just a typo. (Not that the guidelines clearly say that 0.2%{?dist}.20090130svn is invalid, but I agree that 0.2.20090130svn%{?dist} makes more sense.) > * Isn't plasma-devel provided by kdelibs-devel which is one of the dependencies > of kdebase-workspace-devel? So, that BR seems redundant. What if we make a separate plasma-devel one day? But those "redundant" BRs have also been removed from other packages so I can remove it from this one too. > * Fedora-specific flag -fexceptions is overriden by -fno-exceptions but I think > this is a problem with the compilation of kde itself. Can this be fixed? It's a KDE "feature". I can bring this up at the next KDE SIG meeting. But does it really matter for this package? It makes sense for a library > * Do we really need call ldconfig on post{,un} ? Good question. I think we don't, as there's no public shared library, only a plugin in %{_kde4_libdir}/kde4. I'll remove it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review