Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-HomeDir - Get the home directory for yourself or other users https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202317 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |tibbs@xxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-08-12 23:01 EST ------- Boring easy Perl module review follows: * source files match upstream: 295ee8b4f580bea5fa5714cdf8ac965b File-HomeDir-0.58.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(File::HomeDir) = 0.58 perl(File::HomeDir::Darwin) = 0.58 perl(File::HomeDir::MacOS9) = 0.58 perl(File::HomeDir::TIE) perl(File::HomeDir::Unix) = 0.58 perl(File::HomeDir::Windows) = 0.58 perl-File-HomeDir = 0.58-1.fc6 = perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(File::Spec) perl(base) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful, 4 subtests skipped. Files=3, Tests=35, 0 wallclock secs ( 0.10 cusr + 0.04 csys = 0.14 CPU) (the skipped dests are meaningless except on Windows) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review