Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483250 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-01-30 10:04:04 EDT --- After a quick look at your spec file, some comments. - Use '%defattr(-,root,root,-)' instead of '%defattr(-, root, root, 0755)' - The 'URL:' should point to the upstream website. The 'Source0' to the upstream tarball. Move 'URL:' to 'Source' https://fedoraproject.org/wiki/Packaging/SourceURL - It would be nice if you are going to use the dist tag -> 'Release: 2%{?dist}' - Change 'examples' to 'examples/' to add all example files. To get sponsored -> https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review