Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477818 Lucian Langa <cooly@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Lucian Langa <cooly@xxxxxxxxxxxx> 2009-01-30 01:43:00 EDT --- OK source files match upstream: faf236290f222df013198cb0e9cb8555 gsql-0.2.1.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK summary is OK. OK description is OK. OK dist tag is present. OK build root is OK. OK license field matches the actual license. OK license is open source-compatible. OK license text included in package. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (rawhide, x86_64). OK package installs properly. OK debuginfo package looks complete. OK rpmlint is not silent. gsql.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsql.schemas gsql-plugins.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsql-plugins.schemas gsql-engine-mysql.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsql-engine-mysql.schemas -Safe to ingore gsql.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libgsql.so gsql-plugins.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/plugins/libgsqlplugin_vte.so gsql-plugins.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/plugins/libgsqlplugin_runner.so gsql-plugins.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/plugins/libgsqlplugin_exporter.so gsql-engine-mysql.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/engines/libgsqlengine_mysql.so -Safe to igore as package uses g_load_module to load this so files. OK final provides and requires are sane: gsql-0.2.1-1.fc11.x86_64.rpm libgsql.so.0()(64bit) gsql = 0.2.1-2.fc11 gsql(x86-64) = 0.2.1-2.fc11 = /bin/sh GConf2 desktop-file-utils gsql-engine-mysql = 0.2.1-2.fc11 libICE.so.6()(64bit) libORBit-2.so.0()(64bit) libSM.so.6()(64bit) libart_lgpl_2.so.2()(64bit) libatk-1.0.so.0()(64bit) libbonobo-2.so.0()(64bit) libbonobo-activation.so.4()(64bit) libbonoboui-2.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgconf-2.so.4()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglade-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnome-2.so.0()(64bit) libgnomecanvas-2.so.0()(64bit) libgnomeui-2.so.0()(64bit) libgnomevfs-2.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsql.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libgtksourceview-2.0.so.0()(64bit) libnotify.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpopt.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxml2.so.2()(64bit) gsql-devel-0.2.1-1.fc10.x86_64.rpm pkgconfig(libgsql) = 0.2.1 gsql-devel = 0.2.1-2.fc11 gsql-devel(x86-64) = 0.2.1-2.fc11 = /usr/bin/pkg-config gsql = 0.2.1-2.fc11 pkgconfig gsql-engine-mysql-0.2.1-2.fc11.x86_64.rpm libgsqlengine_mysql.so.0()(64bit) gsql-engine-mysql = 0.2.1-2.fc11 gsql-engine-mysql(x86-64) = 0.2.1-2.fc11 = /bin/sh gsql = 0.2.1-2.fc11 libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsql.so.0()(64bit) libgsqlengine_mysql.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libmysqlclient_r.so.16()(64bit) gsql-plugins-0.2.1-2.fc11.x86_64.rpm libgsqlplugin_exporter.so.0()(64bit) libgsqlplugin_runner.so.0()(64bit) libgsqlplugin_vte.so.0()(64bit) gsql-plugins = 0.2.1-2.fc11 gsql-plugins(x86-64) = 0.2.1-2.fc11 = /bin/sh gsql = 0.2.1-2.fc11 libc.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglade-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsql.so.0()(64bit) libgsqlplugin_exporter.so.0()(64bit) libgsqlplugin_runner.so.0()(64bit) libgsqlplugin_vte.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libvte.so.9()(64bit) OK %check is not present; no test suite upstream. OK shared libraries installed; ldconfig called properly OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK scriptlets present look OK OK code, not content. OK documentation is small, so no -doc subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers are in a separate -devel package. OK pkgconfig files present; pkgconfig dependency present OK no static libraries. OK no libtool .la files. OK desktop files valid and installed properly Suggestion: - please consider preserving timestamps of installed files call make install with INSTALL="install -p" APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review