Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482863 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-01-30 01:12:18 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1092737 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 24ff349f0e2e09ca89e8ecbc73b0dc65 MooseX-Daemonize-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=9, Tests=82, 15 wallclock secs ( 0.01 usr 0.01 sys + 1.91 cusr 0.26 csys = 2.19 CPU) + Package perl-MooseX-Daemonize-0.08-2.fc11 => Provides: perl(MooseX::Daemonize) = 0.08 perl(MooseX::Daemonize::Core) = 0.01 perl(MooseX::Daemonize::Pid) = 0.01 perl(MooseX::Daemonize::Pid::File) = 0.01 perl(MooseX::Daemonize::WithPidFile) = 0.01 perl(Test::MooseX::Daemonize) = 0.03 perl(Test::MooseX::Daemonize::Testable) Requires: perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::Daemonize::Pid::File) perl(MooseX::Getopt) perl(MooseX::Getopt::OptionTypeMap) perl(MooseX::Types::Path::Class) perl(POSIX) perl(Sub::Exporter) perl(Test::Builder) perl(strict) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review