Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481717 --- Comment #4 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-01-29 10:46:32 EDT --- (In reply to comment #3) > (In reply to comment #2) > > - Please place the changelog section at the end of the file. It's not wrong > > just unusual. > > done Again 'changelog', if you make any changes on the spec file, you must bump the release of the package. More details at https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs . > > > - This application has a GUI. You need to install the .desktop file. > > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files > > desktop file is part of the upstream tarball and is installed during 'make > install' If 'make install' is taking care of the .desktop file installation, then 'validate' is the right way if the categories match the 'Desktop Entry Specification'. https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Without any further investigations I think that 'Requires: qt' is not necessary, for me it looks like that rpm will pick this automatically. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review