Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466906 --- Comment #7 from Miroslav Suchy <msuchy@xxxxxxxxxx> 2009-01-29 05:04:34 EDT --- > Requires(pre): perl(Class::MethodMaker) > This is very likely wrong. OK. There it seems that pure Requires: perl(Class::MethodMaker) Should be ok. > Package is noarch => OPTIMIZE doesn't make any sense OK. Will remove it. > Please add perl-sig to InitialCC like most perl-packagers do. I did not know it. I overlooked it in guidelines. Will do next time. > - "make test" is claimed to require "root". > I recommend to add an rpm option to run this testsuite All the test in this package require root. So making them optional will be the same as skipping it entirely. IMHO. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review