Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482827 --- Comment #3 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-01-28 15:39:43 EDT --- Good: + License tag has the right specification GPLv2 Bad: - Package name don't fits nameing guildlines. The package is a addon for banshee with the own name of mirage from the upstream author. So the pacnage name should be banshee-mirage. Please refer to https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29 We are not on Debin/Ubuntu. I know, that they have any packages with other package names then here on Fedora. - Mixed use of $RPM_BUILD_ROOT and %{buildroot} - Removing of the nil statement was a bad idea, because we get now a debuginfo package which is useless, because the most part of the application is writeen for the mono plattform. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review