Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482827 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-01-28 14:07:43 EDT --- Good: + Base name of the SPEC file matches to package name + Buildroot will be cleaned at the beginn of %clean and %install + Local build works fine + Can download upstream tar ball with spectool + Tar ball in package matches with upstream (md5sum: 7ebb939d44b64667eaa90ab1ef9a2220) + Package contains License tag + Package contains a verbatin copy of the license text + Buildroot declaration is ok + Package contains no patches + Package has not subpackages + $RPM_OPT_FLAGS are used during the build + Excluding of pp64 is ok + Local build works fine + Start of banshee with install package works + Local install works fine + Local uninstall works fine + Koji build works fine + %doc stanza is small, so we need no deparate doc subpackage + Packaged files of proper permissions + Packaged files are owned by the package + Package files have no comflict to other packages + Buildroot will be cleaned at the beginning of %clean and %install + *.a and *.la file are remove in the %install stanza + Package use %find_lang for i18n + Proper Changelog Bad: - IMHO the package name should be banshee-mirage instead of banshee-extension-mirage - Mixed use of $RRP_ROOT_BUILD and %{buildroot} - Package has no %{?_smp_mflags} without a comment why - Package banshee-musicbrainz-devel doesn't exit in Fedora repository, but I could not found a blocker bug for a review of this package - Rpmlint complaints for source package: $ rpmlint banshee-extension-mirage-0.4.0-1.fc10.src.rpm banshee-extension-mirage.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) banshee-extension-mirage.src: W: invalid-license X11/MIT 1 packages and 0 specfiles checked; 0 errors, 2 warnings. - rpmlint complaints binary rpm: $ rpmlint banshee-extension-mirage-0.4.0-1.fc10.x86_64.rpm banshee-extension-mirage.x86_64: W: invalid-license X11/MIT banshee-extension-mirage.x86_64: W: unstripped-binary-or-object /usr/lib64/libmirageaudio.so banshee-extension-mirage.x86_64: E: invalid-soname /usr/lib64/libmirageaudio.so libmirageaudio.so 1 packages and 0 specfiles checked; 1 errors, 2 warnings. - License tag catins wrong license specification. A short review of the copyright notes in the source files show that GPLv2+ may be the right specificiation for the license tag) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review