Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #5 from Debarshi Ray <debarshi.ray@xxxxxxxxx> 2009-01-28 14:35:31 EDT --- > + According to > https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make you should > use 'make %{?_smp_mflags}' whenever possible. In this case since upstream > supports parallel builds you should use it. You have missed this one. Sorry for not mentioning this earlier, but thanks to the new RPM in Rawhide the following Requires in the -devel sub-package are redundant: Requires: libgnomeui-devel Requires: atk-devel Requires: libbonobo-devel Requires: gtk2-devel Requires: gail-devel Requires: libwnck-devel Requires: esound-devel Requires: at-spi-devel Requires: pkgconfig [rishi@freebook tmp]$ rpm --requires -qp gok-devel-2.25.3-3.fc11.x86_64.rpm /usr/bin/pkg-config [...] pkgconfig(atk) pkgconfig(cspi-1.0) pkgconfig(esound) pkgconfig(gail) pkgconfig(gtk+-2.0) pkgconfig(libbonobo-2.0) pkgconfig(libgnomeui-2.0) pkgconfig(libspi-1.0) pkgconfig(libwnck-1.0) Even though https://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files still mandates the use of 'Requires: pkgconfig', Spot confirmed that they are not needed from Fedora 11 onwards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review