Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481411 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-01-27 09:43:23 EDT --- + is OK - Need work Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1085955 + rpmlint is silent for SRPM - rpmlint is NOT silent for RPM. perl-Test-Email.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Test-Email-0.04/Changes perl-Test-Email.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Test-Email-0.04/README ==>This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. + source files match upstream url bb409977cffb292cd85d80d10506f59e Test-Email-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.15 cusr 0.01 csys = 0.17 CPU) + Package perl-Test-Email-0.04-1.fc11 -> Provides: perl(Test::Email) = 0.04 perl(Test::POP3) = 0.05 Requires: perl(Carp) perl(MIME::Parser) perl(Mail::POP3Client) perl(Test::Builder) perl(Test::Email) perl(base) perl(strict) perl(warnings) Suggestion:- 1) Fix rpmlint message before importing to cvs. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review