Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481564 Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> 2009-01-27 08:49:45 EDT --- I can't access your src.rpm files (2009-01-27 11:37:09 ERROR 404: Not Found) but here are the review. GOOD -> - no rpmlint's message. rpmlint /home/itamar/rpmbuild/SRPMS/bind-to-tinydns-0.4.3-2.fc10.src.rpm \ /home/itamar/rpmbuild/RPMS/x86_64/bind-to-tinydns-0.4.3-2.fc10.x86_64.rpm \ /home/itamar/rpmbuild/RPMS/x86_64/bind-to-tinydns-debuginfo-0.4.3-2.fc10.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - package builds fine in koji (dist-F11) http://koji.fedoraproject.org/koji/taskinfo?taskID=1085805 - package meets naming and versioning guidelines. - specfile is properly named, is cleanly written and uses macros consistently. - dist tag is present. - latest version is being packaged. - BuildRequires are proper. - %clean is present. - package installs properly. - debuginfo package looks complete. - no scriptlets present. - license is open source-compatible. - package works as expected SHOULD VERIFY -> license sounds like GPLv2 for me instead GPLv2+ I see no blocker issue ------------------------------------------------------------ This package (bind-to-tinydns) is APPROVED by itamarjp ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review