Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481717 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-01-27 07:14:31 EDT --- Some quick comments on your spec file - Please place the changelog section at the end of the file. It's not wrong just unusual. - Please add the dist tag to Release -> 'Release: 1%{?dist}' - You don't need to define macros at the beginning of the file. 'Name:' and 'Version:' are already macros. But you must use macros in the %files section https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Please preserve the time stamps, use ' make install DESTDIR=%{buildroot} INSTALL="install -p" ' if possible instead of ' make install INSTALL_ROOT=%{buildroot} ' - This application has a GUI. You need to install the .desktop file. https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - COPYRIGHT and LICENSE must be added as %doc in the %files section. Maybe adding the sample files (out of data/samples in the source) is also a good idea. - There are 'unowned directories' in your %files section. https://fedoraproject.org/wiki/Packaging/UnownedDirectories -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review