Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477144 --- Comment #3 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-01-26 14:19:18 EDT --- Spec URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed-1.1.2-1.fc10.src.rpm (In reply to comment #2) > Here's the review for this one. > > * The prebuilt binaries need removed in %prep > ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.core_1.0.1.jar > ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.ui_1.0.1.jar > ./com.cthing.cmakeed.site/features/com.cthing.cmakeed.feature_1.0.1.jar > Fixed. > * I believe that > ./com.cthing.cmakeed.ui/doc/* > should go to %doc. These don't end up in the RPM otherwise, right? No. This is documentation that is part of com.cting.cmakeed.ui_*.jar and is the documentation shown inside the editor. > > * Please make the description span across 80 columns. It'll look nicer. Fixed. > > * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT > mixed. This needs corrected. You should also use %{__install} for consistency. Fixed. > > * Please make use of the %{version} macro, e.g. in Source0 Fixed. > > * Latest version must be packaged. Please update to 1.1.1 Fixed. Updated to version 1.1.2. > > * There is no license file in the sources. The upstream should be notified to > include a license file. Fixed. Upstream released new version with License.html in it for us. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review