Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481567 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-01-26 10:33:19 EDT --- Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1083163 + rpmlint is silent for SRPM and for RPM. + source files match upstream url bddb5edbe0e3e325d84eb4e5c6a49e7d MooseX-Async-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=1, Tests=6, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.35 cusr 0.02 csys = 0.38 CPU) + Package perl-MooseX-Async-0.07-1.fc11 -> Provides: perl(MooseX::Async) = 0.07 perl(MooseX::Async::Meta::Class) perl(MooseX::Async::Meta::Method::State) perl(MooseX::Async::Meta::Role) perl(MooseX::Async::Meta::Trait) Requires: perl(Moose) perl(Moose::Role) perl(MooseX::Async::Meta::Method::State) perl(MooseX::AttributeHelpers) perl(strict) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review