Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481530 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-01-26 06:18:51 EDT --- Review: + package builds in mock (rawhide i386). koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1081908 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 03e406a8f20f442684f0c83c5f8987cf Fedora-Bugzilla-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=14, Tests=6, 14 wallclock secs ( 0.00 usr 0.01 sys + 13.44 cusr 0.97 csys = 14.42 CPU) + Package perl-Fedora-Bugzilla-0.03-1.fc11-> Provides: perl(DateTime::Format::Bugzilla) = 0.03 perl(Fedora::Bugzilla) = 0.03 perl(Fedora::Bugzilla::Bug) = 0.03 perl(Fedora::Bugzilla::Bug::Attachment) = 0.03 perl(Fedora::Bugzilla::Bug::Comment) = 0.03 perl(Fedora::Bugzilla::Bug::Flag) = 0.03 perl(Fedora::Bugzilla::Bug::NewAttachment) = 0.03 perl(Fedora::Bugzilla::Bugs) = 0.03 perl(Fedora::Bugzilla::NewBug) = 0.03 perl(Fedora::Bugzilla::QueriedBugs) = 0.03 perl(Fedora::Bugzilla::Role::NewHash) = 0.03 perl(Fedora::Bugzilla::Types) = 0.03 Requires: perl(DateTime::Format::Bugzilla) perl(DateTime::Format::Builder) perl(Email::Address) perl(Fedora::Bugzilla::Bug) perl(Fedora::Bugzilla::Bug::Attachment) perl(Fedora::Bugzilla::Bug::Comment) perl(Fedora::Bugzilla::Bug::Flag) perl(Fedora::Bugzilla::Bug::NewAttachment) perl(Fedora::Bugzilla::Bugs) perl(Fedora::Bugzilla::NewBug) perl(Fedora::Bugzilla::QueriedBugs) perl(Fedora::Bugzilla::Types) perl(HTTP::Cookies) perl(MIME::Base64) perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::AttributeHelpers) perl(MooseX::StrictConstructor) perl(MooseX::Types) perl(MooseX::Types::DateTime) perl(MooseX::Types::DateTimeX) perl(MooseX::Types::Moose) perl(MooseX::Types::Path::Class) perl(MooseX::Types::URI) perl(Path::Class) perl(RPC::XML::Client) perl(Regexp::Common) perl(URI::Fetch) perl(URI::Find) perl(XML::Twig) perl(namespace::clean) perl(overload) perl(strict) perl(warnings) Suggestions 1) Good if you upload source to fedorahosted.org using command scp -p Fedora-Bugzilla-0.03.tar.gz fedorahosted.org:camelus which will give you source url as https://fedorahosted.org/releases/c/a/camelus/Fedora-Bugzilla-0.03.tar.gz APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review