Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jfbterm - Japanese Console for Linux Frame Buffer Device https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201170 paul@xxxxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |paul@xxxxxxxxxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-10 08:43 EST ------- You will need to fix the permissions and mixed use of spaces and tabs Not sure about all the stuff at the top for determining the distro used - there seems to be alot in there for pre FC4. As FC4 is now officially in legacy, are you sure you need to go back that far? This is release 1, not 0 efont is another package and should be submitted as such. You then use R:<package_name> (or BR if you need to use it to build). [ %{buildroot} != '/' ] || exit 1 isn't required You will also need BR : iconv What you need to do before a full review occurs is this 1. Decide how far back you want this package to go. If you really want it to go back prior to FC4, I would recommend either seeking advice on the Fedora Extras list or seeing what problems you will encounter as the distros get older and updates don't happen. 2. If you only support FC5 and FC6, you'll need to ditch a lot of the spec file 3. Separate out the fonts and source package and make this package drag in the fonts. Remember, other packages can make use of the fonts. You will need to submit that as another package for review and put a blocker on this package as it relies on the fonts package. 4. Fix the permissions - they won't be let through unless they're correctly set 5. Add BR iconv 6. Add BR whatever provides tic -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review