Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479546 --- Comment #11 from Patrick Dignan <dignan.patrick@xxxxxxxxx> 2009-01-25 04:36:08 EDT --- Alright, I've looked at his spec file and patches, and mostly the changes look good to me. One thing I'm going to try is using sed instead of this code: if [ "$1" = 0 ] ; then if [ -f %{_sysconfdir}/shells ] ; then TmpFile=`/bin/mktemp %{_tmppath}/.jk_chrootshrpmXXXXXX` grep -v '^%{_sbindir}/jk_chrootsh$' %{_sysconfdir}/shells > $TmpFile cp -f $TmpFile %{_sysconfdir}/shells rm -f $TmpFile fi fi I'll test something like sed 's:^%{_sbindir}/jk_chrootsh$::g' %{_sysconfdir}/shells but I'm not sure if that would make sed a BuildReq, if so I'd just stick with Dale's implementation. Other than the %preun %post %postun and the accompanying patches, his spec is pretty much the same as mine (or at least provides the same functions). So I'll add those things to mine and test it tomorrow hopefully. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review