[Bug 198758] Review Request: gnome-phone-manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-phone-manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198758





------- Additional Comments From cweyl@xxxxxxxxxxxxxxx  2006-08-10 11:32 EST -------
Requested changes have been made to spec file.

Looking back over the guidelines, there doesn't appear to be an explict
dependency  on a %check section.  (Normally it's a good idea to have something
of the form "%check\nmake test". See, e.g., almost any perl module package spec
file.)  As this package has no test suite, it doesn't make much sense for me to
insist on it :)

The package builds in mock(5/x86_64) after I added "BuildRequires: 
desktop-file-utils" to the spec.  Add it and I'll approve...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]