Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2009-01-24 02:57:35 EDT --- Some remarks on your spec: * BuildRequires: > BuildRequires: openssh, binutils I don't understand why you "BR: openssh". "BR: binutils" definitely is redundant. Could it be, you intend to "BR: binutils-devel" to pull in libiberty? > BuildRequires: glib-devel, xorg-x11-proto-devel BR: glib-devel is very likely wrong (glib-devel is a glib1 package). You likely intend to pull in glib2-devel, which already is implicitly pulled in by BR: gtk2-devel BR: xorg-x11-proto-devel I don't see any need to BR: this. [You seem to be building on fc7. This could explain some of your BR's above, because IIRC, several of the packages you reference have seem some significant packaging cleanups since then.] * Source code quality: Building on FC10 exposes an "exciting amount" of "not-so-harmless" warnings. Some of them definitely are worth going after and be fixed. [I have never used skeeye myself, but co-workers, I occasionally work with are using it - AFAICT, they never managed to get skeeye working on x86_64. I can ask them on next occasion ;)] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review