Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jfbterm - Japanese Console for Linux Frame Buffer Device https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201170 paul@xxxxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|202032 | ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-10 11:06 EST ------- Just chewing over the spec - I've not built it yet (my remote machine connection is down) The whole font section in %prep - is this actually required for building the package? The calls to aclocal et al. Normally, the configure system calls them (unless the configure scripts have been messed with and need regenerating). The website certainly says that it's just a matter of running configure/make/make install On the make line, is there a reason for not using _smp_mflags? If there is (for example, it won't build), could you please add a comment to that effect? %{_mandir}/man*/* No. If it needs man1/package-name, then call it that. There are not normally that many man files to install and using /man*/* takes an incorrect ownership. A quick way if there are many files are to glob them together viz %{_mandir}/man1/foo* %{_mandir}/man4/bar* Can you please check them and if just upload a new spec file? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review