Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481141 --- Comment #3 from Matej Cepl <mcepl@xxxxxxxxxx> 2009-01-22 10:04:29 EDT --- First of all: > varování: Nalezeny instalované, ale nezabalené soubory: > /usr/lib/pycryptsetup/examples/selftest.py > /usr/lib/pycryptsetup/examples/selftest.pyc > /usr/lib/pycryptsetup/examples/selftest.pyo Just let it be uninstalled (setup.py would leave it alone) and put examples/ into %doc. And now about the spec file: > %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysc onfig import get_python_lib; print get_python_lib()")} > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sy sconfig import get_python_lib; print get_python_lib(1)")} Only one of these, please. > #I don't want the unpackaged file check > %define _unpackaged_files_terminate_build 0 Why? There is no reason in the world, I would know about, why you don't want it, and actually it would save your from the above blunder. Either explain pretty well in the comment why you need, or get rid of it. > Requires: cryptsetup-luks Needless Requires should be avoided. [matej@viklef redhat]$ rpm -qRp RPMS/i386/pycryptsetup-0.0.1-1.fc10.i386.rpm libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libcryptsetup.so.0 libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) [matej@viklef redhat]$ rpm -q --whatprovides libcryptsetup.so.0 cryptsetup-luks-1.0.6-6.fc10.i386 [matej@viklef redhat]$ > BuildRequires: python-devel Needless BuildRequires should be avoided as well: [matej@viklef ~]$ rpm -qR python-setuptools-devel /usr/bin/python python(abi) = 2.5 python-devel python-setuptools = 0.6c9-1.fc10 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [matej@viklef ~]$ > %attr(0644,root,root) %{_datadir}/doc/%name-%version/COPYING This should be %doc COPYING --- Please replace all occurrences of %{__rm}, %{__install}, %{__mv} and others with direct calls to the real command. (OK, you won with %{__python}) --- Still unhappy rpmlint: [matej@viklef redhat]$ rpmlint -i SRPMS/pycryptsetup-0.0.1-1.fc10.src.rpm [matej@viklef redhat]$ rpmlint -i SRPMS/pycryptsetup-0.0.1-1.fc10.src.rpm pycryptsetup.src: E: no-changelogname-tag There is no %changelog tag in your spec file. To insert it, just insert a '%changelog' in your spec file and rebuild it. pycryptsetup.src: W: strange-permission pycryptsetup.spec 0600 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. [matej@viklef redhat]$ --- Source0 should be URL -- https://fedoraproject.org/wiki/Packaging/SourceURL Cannot compare MD5 checksum with upstream. URL: field doesn't make sense as well. Please, make the upstream for it and THEN file a version of the package for review. --- It does build in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=1074220) but it shouldn't because of broken %files -- see the top of this comment. Please fix all the above problems, build upstream, and then we can go through the next round of review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review