Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleggl - OpenGL support library for Allegro https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201198 ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2006-08-10 13:39 EST ------- * rpmlint: no problems * Package named correctly: Yes * Patches named correctly: N/A * Spec file named correctly: Yes * Licence field matches: Yes * Licence file installed: No (OK but should query upstream) * Spec file in American English: Yes * Source matches upstream: Yes * Locales use %find_lang: N/A * Contains %clean: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock: fc5/ppc) * Calls ldconfig in %post/%postun for shlibs: Yes * Owns directories it creates: Yes * Duplicate files: No * Permission set correctly: Yes * Consistent macro use: Yes * %doc affects runtime: No * Headers and static libs in -devel: Yes * .pc files in -devel: N/A * .so in -devel: Yes * -devel requires base: Yes * Contains .la files: No * Owns files it didn't create: No * .desktop files installed correctly: N/A 1. As it needs allegro >= 4.2.0, i suggest putting a version dependency on allegro-devel for both the base and -devel packages 2. As faq.txt contains information exclusively of interest to developing/ building with alleggl I suggest moving it to -devel 3. readme.txt is primarily build instructions, I suggest excluding it. 4. In -devel, the *.hhk *.hhc and *.hhp files are Microsoft Windows HTML Help files if I remember right, probably of no interesting in Linux, I would exclude them. Otherwise it's cool. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review