Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475097 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-01-21 09:19:31 EDT --- ! First of all: Please check your srpm / rebuilt binary rpms using "rpmlint" (in rpmlint rpm). This will detect some generic packaging errors. For 0.3.2-1: * odd issue in srpm - Please change the permissions of all files in srpm to 0644. * disttag - Please consider to use %{?dist} tag: https://fedoraproject.org/wiki/Packaging/DistTag * Macros in SourceURL - Using %{name}, %{version}, especially %{version} in SourceURL is recommended: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D * Misc rpmlint issue ------------------------------------------------------------ W: summary-ended-with-dot A simple plug-in to do fourier transform on you image. E: description-line-too-long A simple plug-in to do fourier ... ------------------------------------------------------------ - Summary must not end with dot. - Please shorten the length of a line in %description. It should not exceed 79 characters. * License - The licene tag "GPL" is invalid on Fedora. https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL For this package the license tag should be "GPLv3+". * (Build)Requires - Please check if "BuildRequires: gimp" is needed. - "Requires: fftw3" is definitely unneeded. Such library related dependencies are automatically detected by rpmbuild itself and rpmbuild correctly adds those dependencies. ! "Requires: gimp" is needed for this case because of directory ownership issue * compiler flags - Fedora specific compiler flags are not honored correctly. https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags This can be specified by %optflags (you can check what compiler flags must be honored by $rpm --eval %optflags) ! As a result, currently debuginfo rpm creation is incomplete. * $RPM_BUILD_ROOT vs %{buildroot} - Choose one. Please don't use both. * Directory ownership issue - The directory %{_libdir}/gimp/2.0{,/plug-ins} themselves should not be owned by this package: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership * Documents - Please add the following file(s) to %doc. ------------------------------------------------- README gpl.txt ------------------------------------------------- ! By the way README files are not in UTF-8, and this has CRLF, LF line terminators. Please fix these. * %changelog - We recommend that one line is put between each %changelog entry (it will be helpful in Fedora CVS), like: ------------------------------------------------- * Mon Jan 19 2009 Fabian Deutsch <fabian.deutsch at gmx.de> 0.3.2-1 - Updated to 0.3.2 - Includes license note - Small hack around gimptool-2.0 bug. * Sun Dec 07 2008 Fabian Deutsch <fabian.deutsch at gmx.de> 0.3.1-1 - Version 0.3.1 - Initial. ------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review