Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474802 Gratien D'haese <gratien.dhaese@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gratien.dhaese@xxxxxx --- Comment #6 from Gratien D'haese <gratien.dhaese@xxxxxx> 2009-01-20 17:12:38 EDT --- $ rpmlint -vi vacation-1.2.7.0-3.fc9.src.rpm vacation.src: I: checking vacation.src:90: W: macro-in-%changelog post Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. vacation.src:91: W: macro-in-%changelog postun Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. ==> read and apply to your changelog vacation.src: W: strange-permission vacation-1.2.7.0.tar.gz 0640 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. ==> set the correct permissions before rpmbuild process starts 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmbuild -ba SPECS/vacation.spec builds OK $ rpmlint -vi RPMS/x86_64/vacation-1.2.7.0-3.fc9.x86_64.rpm vacation.x86_64: I: checking vacation.x86_64: W: incoherent-version-in-changelog 1.2.7.0-1 ['1.2.7.0-3.fc9', '1.2.7.0-3'] The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. ==> changelog entry and version must match => Release: 3%{?dist} => first line in %changelog 1.2.7.0-1 << 3 not 1 vacation.x86_64: W: dangerous-command-in-%post ln vacation.x86_64: W: dangerous-command-in-%postun rm vacation.x86_64: W: dangerous-command-in-%trigger ln vacation.x86_64: W: dangerous-command-in-%trigger rm 1 packages and 0 specfiles checked; 0 errors, 5 warnings. => probably no way around this. $ rpm -qp --requires RPMS/x86_64/vacation-1.2.7.0-3.fc9.x86_64.rpm /bin/sh /bin/sh /bin/sh /usr/bin/perl libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgdbm.so.2()(64bit) perl >= 1:5 perl(GDBM_File) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) smtpdaemon => spec file misses: Requires: /usr/bin/perl I would add it, but opinions may differ. => in spec file "License: GPLv2 and BSD" : looking at vacation.c I note that we're dealing with the "Original BSD License (BSD with advertising)" and checking url http://fedoraproject.org/wiki/Licensing#SoftwareLicenses learn us that it is not compatible with GPLv2 ! That must be fixed somehow - check the documentation what is acceptable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review