Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=188542 --- Comment #97 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> 2009-01-20 07:50:28 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=1068402 package built fine in dist-f10 for all supported arches. The historic of this review is huge, I haven't read all for now. So that's just few notes. (probably not a complete review). * As the package is already hylafax, You don't need to have Provides: hylafax * BuildRequires: ... gcc, gcc-c++ - Those aren't needed as they are implicitly added in the BuildDependency and shouldn't be mentioned. (older fedora version will need this indeed). * Conflicts: mgetty-sendfax - We need to find a solution to avoid conflict. and implement a proper alternative. Since this can probably not hit F-9/F-10 * http://koji.fedoraproject.org/koji/getfile?taskID=1068404&name=build.log - JBIG library was not found on x86_64 Checking for JBIG library support ... not found. Disabling JBIG support Can the support for this can be enabled ? (it needs to be added as BuildRequires first) * Various checks are made at build time: WARNING, could not locate sendmail on your system. Beware that the mail notification work done by this software uses sendmail-specific command line options. If you do not have a sendmail-compatible mailer things will break. ... WARNING, no egetty program found, using /bin/egetty. ... Looks like /usr/bin/gs is the PostScript RIP to use. WARNING, /usr/bin/gs does not seem to be an executable program; -> Does the necessary Requires: are requested for the runtime ? either using Requires on the package, or the "virtual provides" or on the program path name. * rpmlint on installed package: [root@kwizatz Téléchargement]# rpmlint hylafax hylafax.x86_64: E: executable-marked-as-config-file /etc/cron.hourly/hylafax hylafax.x86_64: E: executable-marked-as-config-file /etc/cron.daily/hylafax hylafax.x86_64: E: useless-provides hylafax hylafax.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfaxutil.so.5.2.8 /lib64/libm.so.6 hylafax.x86_64: W: undefined-non-weak-symbol /usr/lib64/libfaxserver.so.5.2.8 HYLAFAX_VERSION_STRING hylafax.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfaxserver.so.5.2.8 /lib64/libm.so.6 1 packages and 0 specfiles checked; 3 errors, 3 warnings. -> the cron scripts should probably stay as %config files -> the undefined-non-weak-symbol /usr/lib64/libfaxserver.so.5.2.8 HYLAFAX_VERSION_STRING can probably be fixed. * --with-PAGESIZE=A4 - I appreciate that my standard page format to be set as default, but is there a way to have this fixed at runtime while using system wide configuration files for localization ? (I haven't made runtime test, as i don't have the required hardware/phone connection. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review