Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477533 --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-01-19 12:04:22 EDT --- Thank you for initial comments. (In reply to comment #3) > rubygem-mechanize.noarch: E: zero-length > /usr/lib/ruby/gems/1.8/gems/mechanize-0.9.0/lib/www/mechanize/chain/post_connect_hook.rb - From quick glance it does not seem to be needed, however for now I will leave this file as it is. > I see that both rubygem-gettext-doc and rubygem-zoom-doc install their > documentation (examples,test) inside %doc > What is the reason that this package is different? - The way on this package is usual. For the other two packages (especially for rubygem-gettext) I wanted to strip gem file itself so I removed some document files from gem itself and installed the removed files by %doc method. > rubygem-mechanize-doc.noarch: E: script-without-shebang > /usr/lib/ruby/gems/1.8/gems/mechanize-0.9.0/test/htdocs/google.html - Fixed. > * I don't think we need to package Manifest.txt. - Removed. > * The license file and the website license page say GPLv2+. The source code > files do not indicate a license. I think setting the license as GPLc2+ will be > more appropriate. - Well, what URL shows that this is under GPLv2"+"? (note that I saw that rubyforge.org website says that this is under GPLv2, however I guess this license tag is automatically tagged from license text. Moreover I saw that in many cases the license tag on website is wrong....) > * Latest version must be packaged. I can't find any information to confirm > this. Where is download section on the website? - See: http://gems.rubyforge.org/gems/ > * Ruby guidelines say: "A ruby extension/library package must indicate what it > provides with a Provides: ruby(LIBRARY) = VERSION declaration in the spec file" > So I think > Provides: ruby(%{gemname}) = %{version}-%{release} > Provides: rubygem(%{gemname}) = %{version}-%{release} > must be changed to > Provides: ruby(%{gemname}) = %{version} > Provides: rubygem(%{gemname}) = %{version} - Provides: rubygem(%{gemname}) = %{version}-%{release} also provides rubygem(%{gemname}) = %{version} and I want to write this more strictly for some reason. > * Do we need this line:? > #Requires: rubygem(hoe) - This dependency is implied by gemspec file, however currently I don't see this is needed. So for now I want to keep this comment. http://mtasaka.fedorapeople.org/Review_request/rubygem-mechanize/rubygem-mechanize-0.9.0-2.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-mechanize/rubygem-mechanize.spec * Tue Jan 20 2009 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> - 0.9.0-2 - Some cleanup For dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1066652 For dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1066658 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review