Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478769 D Haley <mycae@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mycae@xxxxxxxxx --- Comment #5 from D Haley <mycae@xxxxxxxxx> 2009-01-19 05:11:02 EDT --- Hi Aurelien, OK, I have quickly looked at the spec for this one -- I am not able to provide a solid review at this stage. If I get time (weekend), I may provide patches to some of these, if you like. * Not sure about grabbing the data from what appears to be part of their filesystem that is laid out to fit neatly into the ubuntu repository. Might be a bit too dynamic... The Git repository sounds like a much better idea. * I think offering an installer for a TA mod "CA" may have licencing issues. TA is copyright of what used to be infogrames, which i know think is Atari. The content that this installer obtains is probably copyright protected, as I undesrtand that Complete Annihilation uses TA game data. * Is specifying the content of the sub-package in the main package description normal? I have not seen this before, and it strikes me as a touch confusing. * Using chrpath to remove hardcoding of path information is considered a last resort option [1]. Consider patching the build system to remove invocations to chrpath. [1] http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review