Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480538 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jochen@xxxxxxxxxxxxxxx --- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-01-18 15:35:14 EDT --- Good: + Basename of SPEC files matches with package name + Package contains a License tag + Package contains most recent release of the software + %setup use -q flag + make use _smp_mflags + Local build works fine. + Debuginfo package contains source files + Buildroot will be cleaned on the beginning of %install andn %clean + Files permissions seems ok + All packaged files are owned by this package + There are no file comflict with other packates. + %doc stanza contains a small amount of files, so we need no separate doc subpackage Bad: - License tag contains no proper license specification, it should be GPLv2+ - Source0 tag is not full qualified - Build doesn't use RPM_OPT_FLAGS - Rpmlint complaints on source package: iptux.src: W: summary-ended-with-dot A software for sharing in LAN. iptux.src: W: non-standard-group Application/Network iptux.src: W: invalid-license GNU General Public License v2 - Rpmlint complaints on binary package: rpmlint iptux-0.4.4-3.fc10.x86_64.rpm iptux.x86_64: E: explicit-lib-dependency glib iptux.x86_64: W: summary-ended-with-dot A software for sharing in LAN. iptux.x86_64: W: non-standard-group Application/Network iptux.x86_64: W: incoherent-version-in-changelog -0.4.4-3 ['0.4.4-3.fc10', '0.4.4-3'] iptux.x86_64: W: invalid-license GNU General Public License v2 iptux.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/iptux.mo - Package contains no verbain copy of the license text, but upstream tar ball contains one - Package contains no BR and Req. to desktop-file-utils - Please ud %{_bindir} instead of %{_prefix}/bin - Build fails on Koji please refer to http://koji.fedoraproject.org/koji/taskinfo?taskID=1064580 - Please use %file_lang macro for localization -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review