[Bug 184331] Review Request: K-3D - 3D modeling and rendering system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: K-3D - 3D modeling and rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184331





------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx  2006-08-09 16:35 EST -------
Okay

Good

Builds fine and actually works
rpmlint is clean on all packages (with the exceptions listed above which I'm
willing to accept)
No dupes in the BRs
Includes documentation
No issues with directory ownership

Bad

Needs pkgconfig adding to the R: on the devel
You've packaged the same README in the main and devel package

Unsure
find -type f -regex '.*\.\(cpp\|h\|svg\)' -perm +111 -exec chmod -x {} ';' -
seems like overkill to me.

Fix the two bads (which aren't that bad!), and it's good to go

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]