Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478767 Aurelien Bompard <gauret@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(ianweller@xxxxxxx | |om) --- Comment #7 from Aurelien Bompard <gauret@xxxxxxx> 2009-01-17 09:56:03 EDT --- > I'll go ahead and review all four package Thanks ! > Problem: Spec file given and spec file in SRPM don't match. See attachment. Oops, sorry about that. Looks like I made a last-minute update to the srpm and I forgot to re-upload the spec file. The dependency on spring-maps-default should be there. > The Description doesn't seem very descriptive. Can you be more specific? OK, I've tried to add a few lines from Wikipedia, and I've added a README.Fedora file. > Commas clutter up the BRs and Requires fields. Well, actually I kind of like it like that, it make separation clearer when using versioned requires. But I don't care very much... :) > - Since spring-engine is a subpackage of spring with the same versioning, > the requires between these packages need to be version/release specific. Hmm, I'm not sure, because the "spring" package here is just a meta-package to pull all needed package to play the game. The meta-package in itself does not care which version of the spring-engine is installed. It's not like -devel subpackages. It's not a problem to add the version either, so if you really feel it should be a versioned dependency, I'll add it. > The --vendor option to desktop-file-install is no longer wanted in new packages. Oh, thanks, I missed that. > There is a new upstream release available Woot ! Updated, thanks. New SRPM: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-0.78.1.1-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review