Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459535 Gratien D'haese <gratien.dhaese@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gratien.dhaese@xxxxxx --- Comment #28 from Gratien D'haese <gratien.dhaese@xxxxxx> 2009-01-15 09:57:54 EDT --- Did a quick check (as new packager) on backup-manager.spec v0.7.7-6 1/ the spec file looks OK to me, but I'm not an expert on the field (wip) 2/ do a build test: $ rpmbuild -ba backup-manager.spec .... remark 1: Requires: /bin/bash /bin/sh ==> see comment #21 (bash is a superset of sh) remark 2: Converting encoding some doc-files + for file in AUTHORS ChangeLog THANKS + mv AUTHORS timestamp + iconv -f ISO-8859-1 -t UTF-8 -o AUTHORS timestamp but later I saw: + cp -pr AUTHORS COPYING ChangeLog NEWS README THANKS /var/tmp/backup-manager-0.7.7-6.fc9-root-makerpm/usr/share/doc/backup-manager-0.7.7 ==> the files NEWS README and THANKS are not converted. Why not? Small check: in spec file I see: %doc AUTHORS COPYING ChangeLog NEWS README THANKS and, [makerpm@localhost backup-manager-0.7.7]$ file THANKS THANKS: UTF-8 Unicode English text [makerpm@localhost backup-manager-0.7.7]$ file README README: ASCII English text remark 3: the "t" directory in the source tree is not very meaningful, why not call it "tests"? ==> I know inspecting the code is not part of the packaging guidelines, but all bits help. You may ignore this if you want as at the end the tests are not part of the RPM itself. 3/ doing a build with the tarball: [makerpm@localhost rpmbuild]$ rpmbuild -tb -vv /home/makerpm/rpmbuild/SOURCES/backup-manager-0.7.7.tar.gz error: Name field must be present in package: (main package) error: Version field must be present in package: (main package) error: Release field must be present in package: (main package) error: Summary field must be present in package: (main package) error: Group field must be present in package: (main package) error: License field must be present in package: (main package) D: May free Score board((nil)) ==> this fails. Could this be of a missing spec file in the tarball? [makerpm@localhost rpmbuild]$ tar ztf SOURCES/backup-manager-0.7.7.tar.gz | grep spec ==> not found 4/ the remark conc. the development release 0.7.7 is correct. Once the bug report gets a GO (package ready to checked into CVS) make a stable release package instead, e.g. 0.8.0 OK for me, on some minor remarks. Thanks for the learning experience! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review