Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467376 --- Comment #4 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2009-01-15 08:33:18 EDT --- (In reply to comment #3) > Mostly OK. Needs a license file. I'm not quite sure what the > make-pixman-snapshot.sh script is used for. Its not packaged nor used during > the build process that I can see. I presume it must be for creating a > git/svn/cvs snapshot, which AFAICT we're not using a snapshot so does it need > to be included. That file is from the base Fedora pixman package. I just included it so that we keep as close to the base package as possible. It's not used currently in the base package either. > It also doesn't currently build in koji but that's expected due > to the lack of mingw32-dlfcn. It does build without it though. I'm not sure > whether mingw32-dlfcn is currently being reviewed. Its got input on the ticket > but nobody currently has ownership of it. I'm hoping that Adel Gadllah will have a look at mingw32-dlfcn (bug 478640) soon. > + rpmlint output > > $ rpmlint -i mingw32-pixman-0.13.2-1.fc10.src.rpm > mingw32-pixman.src: W: strange-permission make-pixman-snapshot.sh 0775 > A file that you listed to include in your package has strange permissions. > Usually, a file should have 0644 permissions. > > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Not sure what rpmlint is complaining about here :-) It's a shell script, in the SRPM, (potentially) used to build the package, so I don't think this is incorrect. > - %doc includes license file This is annoying isn't it. Upstream don't provide a license file and the base Fedora package doesn't include one either. I've raised the following bug upstream: http://bugs.freedesktop.org/show_bug.cgi?id=19582 Below is a new build which preemptively includes this patch. Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/pixman/mingw32-pixman.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-pixman-0.13.2-2.fc10.src.rpm * Thu Jan 15 2009 Richard W.M. Jones <rjones@xxxxxxxxxx> - 0.13.2-2 - Include LICENSE file (freedesktop bug 19582). $ rpm -qlp /home/rjones/rpmbuild/RPMS/noarch/mingw32-pixman-0.13.2-2.fc11.noarch.rpm /usr/i686-pc-mingw32/sys-root/mingw/bin/libpixman-1-0.dll /usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1 /usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1/pixman-version.h /usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1/pixman.h /usr/i686-pc-mingw32/sys-root/mingw/lib/libpixman-1.dll.a /usr/i686-pc-mingw32/sys-root/mingw/lib/libpixman-1.la /usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/pixman-1.pc /usr/share/doc/mingw32-pixman-0.13.2 /usr/share/doc/mingw32-pixman-0.13.2/LICENSE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review