Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475661 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review+ Bug 475661 depends on bug 475593, which changed state. Bug 475593 Summary: Review Request: fontpackages - Common directory and macro definitions used by font packages https://bugzilla.redhat.com/show_bug.cgi?id=475593 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE --- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-01-14 14:30:21 EDT --- I poked around this package for 2 hours now. I couldn't find any blockers. There are two minor things I think I should say: * Not a blocker but, as I say in all my reviews, I prefer using %defattr(-,root,root,-) * All fonts (including sans-serif ones) say that they are "Serif" as (OS/2) PFM-Family in fontforge. I think upstream needs notified. Other than these two, you might want to wait for the subpackage naming decision of FESCO for http://fedoraproject.org/wiki/PackagingDrafts/Font_package_naming_(2009-01-13) Otherwise, everything is clean ----------------------------------------------------- This package (google-droid-fonts) is APPROVED by oget ----------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review