Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472683 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 | Flag|fedora-review? |fedora-review+ --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-01-14 12:32:18 EDT --- Okay, - For your pre-review for bug 478412, about compiler flags: * %configure macro sets CFLAGS environment value (you can check what %configure does by "$ rpm --eval %configure"). Usually when using configure/Makefile generated by recent autotools this $CFLAGS value is correctly honored. However when using some old configure/Makefile, which are originally written by the upstream developer sometimes these files does not correctly catch $CFLAGS. In such cases you may have to use "CC='gcc %{optflags}'", for example. - For jailkit, packaging itself seems almost good (I wrote some comments) ---------------------------------------------------------- This package (jpcap) is APPROVED by mtasaka ---------------------------------------------------------- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji) ". Now I am sponsoring you. If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Removing NEEDSPONSOR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review