Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479546 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mtasaka@xxxxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-01-14 12:16:33 EDT --- Well, some notes: * License - The License tag should be "LGPLv2+". * BuildRequires - Would you check if "automake, autoconf" is needed for BuildRequires? * optflags - Would you check if 'CC="gcc %{optflags}"' is really needed? * Documents - The file "INSTALL.txt" is usually for people who compiles and installs the software by him/herself and not for people using rpm binary. - Files under %_mandir are automatically regarded as %doc. Well, as this package deals with security issues, I will anyway wait for one week or so before I approve this package to see if who knows how to deal with security software will post some comments on this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review