Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479585 --- Comment #17 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-01-14 11:05:05 EDT --- Good: + Package name fit with nameing guidelines + Name of SPEC file fit with basename of package + Package has a valid open source license + Package contains verbatin copy of the license text + Consistently usage of macros + source can be downloaded via spectool + Tar ball in the package fits with upstreams (md5sum: 366849faf106f4fdfb6e1ff1f72b9e9d) * BUILDROOT will cleaned on the beginning of the %install and %clean stanza + Rpmlint is quiete on source rpm + Package contains no subpackages + Files containing in the package doesn't belongs to others + Content of %doc is small, so no separate subpackage is require + Package will be built on noarch + Local build works fine + Build on koji works fine + Local install works fine + Starting of application without argument works + Removing of the package works fine. Bad: - License tag should be CPLv3+ because the copyright notice on the source files allow the usage of later version of the GPL - Rpmlint complaints on binary rpm: megaupload-dl.noarch: W: spurious-executable-perm /usr/share/doc/megaupload-dl-0.2.1/megaupload_dl_wget.sh megaupload-dl.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/megaupload_dl/lib.py 0644 megaupload-dl.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/megaupload_dl/megaupload_dl.py 0644 - Files on %{_sitedir}/metagupload_dl/*.py should be executables - Files on %{_docdir} should be not executable - __init__.py file should have a shebang -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review