[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474787





--- Comment #6 from D Haley <mycae@xxxxxxxxx>  2009-01-14 07:31:36 EDT ---
SPEC URL: http://dhd.selfip.com/427e/stxxl-3.spec
SRPM URL: http://dhd.selfip.com/427e/stxxl-1.2.1-3.fc10.src.rpm

Rpmlint:
SRPM: empty
SPEC: empty
RPM: empty

>"Summary" of -devel package is not "short and concise" as recommended by the
>guidelines, but two sentences squeezed into an overlong line.
I shortened it in the main package, though I thought it was pretty short to
begin with. In the devel section it has been corrected, as it was clearly
overlong. The main summary is slightly shortened but cannot be shortened
further without losing information.

>Run rpmlint also on your src.rpm

My apologies if I had not -- I thought I had, as stated in comment 3. Clearly
not, as running it produces a myriad of errors.

>src.rpm download URL gives 404 Not Found
Again, that's just sloppy on my part -- I didn't transfer it to the server.
Both the old and the new have been uploaded.

> %description of the -devel package is the same as the description of the main
package.
Fixed. 

> -devel pkg typically must "Requires: %{name} = %{version}-%{release}" to stay
in sync with the main package.
Fixed

> %files devel section contains unowned directories! 
Fixed --  would have been evident had i run rpmlint correctly.

>%files devel section is missing %defattr parameter
Done.

>Note : That could also be the answer to your problem with the .so symlink. The
>symlink must be in the -devel package, and the -devel package requires the main
>package which contains the library file.

It wasn't that -- I worked it out in the end with the help of 
http://en.opensuse.org/Shared_Library_Packaging_Policy . Which was very clear,
both in procedure and rationale. Seems to keep rpmlint happy and matches what
is happening in other packages in my /usr/lib/.


I hope this package is less sloppy than the last attempt!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]