Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460894 --- Comment #6 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2009-01-14 05:33:36 EDT --- (In reply to comment #5) > I can verify it now builds, installs, and runs (only did basic testing) without > error for me on f10-x86_64; thanks Richard. > > A few minor points: > > * /usr/bin/ocsigen is system_u:object_r:bin_t; do we maybe want to make it > system_u:object_r:httpd_exec_t like apache httpd since it's "just" another > webserver? I have absolutely no idea how to do this, but sure it sounds like a good idea. > * I got no -debuginfo package out of the build, and /usr/bin/ocsigen is not > stripped. Debuginfo isn't really that useful for OCaml programs, since gdb doesn't know about OCaml. So you end up having to debug assembler. > * The ocsigen quickstart page indicates most distros include an initscript, > which we seem to be lacking. I'd volunteer but shell scripts make me want to > gouge my eyes out. Probably best to copy the one from Debian, if they have one: http://git.debian.org/?p=pkg-ocaml-maint/packages/ocsigen.git;a=summary > Apart from these potential considerations, looks good to me. Should I start > rabble-rousing on the -devel list to get some real certified reviewers on this? Sure thing! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review