Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: db4o https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201551 ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2006-08-08 17:33 EST ------- Looks almost perfect, except for these new rpmlint warnings: W: db4o-devel no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. It can be ignored. W: db4o-doc non-standard-group Development/Documentation The value of the Group tag in the package is not valid. Valid groups are: [...]"Documentation"[...] I think you should call it just that. :) Oh, and you can also add %define debug_package %{nil} so that the empty debug package isn't generated. Something like that is found in other mono packages, too, and follows the packaging guidelines: http://fedoraproject.org/wiki/Packaging/Debuginfo#head-29573c4f61c3a4698b2d07c7e73cfa194785f257 Running the built Db4oMonoTest.exe seems fine, too. Fix the group tag, disable debuginfo generation, and it's APPROVED. Good work. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review