[Bug 477683] Review Request: fltk2 - C++ user interface toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477683





--- Comment #9 from Michael Schwendt <bugs.michael@xxxxxxx>  2009-01-13 14:30:55 EDT ---
Just skimming over the spec file:


* The guidelines want you to choose either %buildroot or $RPM_BUILD_ROOT, not
both.


* Use "install -p ..." especially when installing files yourself.


* Unowned directories alarm in -devel package! It can easily be seen that the
following %files entries are missing:

%dir %{_includedir}/%{project_name}
%dir %{_includedir}/%{project_name}/compat
%dir %{_includedir}/%{project_name}/compat/FL


> %package       doc
> Summary:       Doxygen documentation for FLTK2
> Group:         Documentation
> Requires:      %{name} = %{version}-%{release}

Why that?

> BuildRoot:     doxygen

Uh? A typo, most likely. Make that  BuildRequires: doxygen

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]